Errors Deploying Worker Module in Terraform

brad.worsfold · December 23, 2021, 5:30pm

I’m trying to deploy a worker using modules and terraform. I get the following error. If I try and use the exact same code using quick edit in the console, it works as expected. Is this a limitation of the terraform provider? Plans on getting this resolved? This is actually preventing me from using this new feature. I’ve also created a support ticket, but sometimes things happen faster here…
{
“result”: null,
“success”: false,
“errors”: [
{
“code”: 10021,
“message”: “Uncaught SyntaxError: Unexpected token ‘export’\n at line 49\n”
}
],
“messages”:
}

fritex · December 23, 2021, 7:15pm

May I just ask was this error related to the below incident, or rather it’s related to the Terraform iteself?:

https://community.cloudflare.com/t/cloudflare-workers-updating-delays/338826?u=fritex

brad.worsfold · December 23, 2021, 7:59pm

I believe this is a terraform specific issue. Error responses are 400 bad requests. I can also make the same changes just fine through the console. So… I think it is a TF issue.

daveb · January 5, 2022, 2:57am

Terraform does not work because the API to upload a worker is broken when trying to upload module based workers. I’ve run into the same issue just using the script upload API without Terraform.

https://api.cloudflare.com/#worker-script-upload-worker

Terraform sources showing it uses the same upload endpoint:

github.com

cloudflare/terraform-provider-cloudflare/blob/master/cloudflare/resource_cloudflare_worker_script.go#L253

    
      
          
          
	bindings := make(ScriptBindings)
          
          
	parseWorkerBindings(d, bindings)
          
          
	scriptParams := cloudflare.WorkerScriptParams{
          		Script:   scriptBody,
          		Bindings: bindings,
          	}
          
          
	_, err = client.UploadWorkerWithBindings(context.Background(), &scriptData.Params, &scriptParams)
          	if err != nil {
          		return errors.Wrap(err, "error updating worker script")
          	}
          
          
	return nil
          }
          
          
func resourceCloudflareWorkerScriptDelete(d *schema.ResourceData, meta interface{}) error {
          	client := meta.(*cloudflare.API)

github.com

cloudflare/cloudflare-go/blob/master/workers.go#L503

    
      
          // API reference: https://api.cloudflare.com/#worker-script-upload-worker
          func (api *API) UploadWorker(ctx context.Context, requestParams *WorkerRequestParams, data string) (WorkerScriptResponse, error) {
          	if requestParams.ScriptName != "" {
          		return api.uploadWorkerWithName(ctx, requestParams.ScriptName, "application/javascript", []byte(data))
          	}
          	return api.uploadWorkerForZone(ctx, requestParams.ZoneID, "application/javascript", []byte(data))
          }
          
          
// UploadWorkerWithBindings push raw script content and bindings for your worker
          //
          // API reference: https://api.cloudflare.com/#worker-script-upload-worker
          func (api *API) UploadWorkerWithBindings(ctx context.Context, requestParams *WorkerRequestParams, data *WorkerScriptParams) (WorkerScriptResponse, error) {
          	contentType, body, err := formatMultipartBody(data)
          	if err != nil {
          		return WorkerScriptResponse{}, err
          	}
          	if requestParams.ScriptName != "" {
          		return api.uploadWorkerWithName(ctx, requestParams.ScriptName, contentType, body)
          	}
          	return api.uploadWorkerForZone(ctx, requestParams.ZoneID, contentType, body)
          }